Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make image lists resizable #2823

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: make image lists resizable #2823

merged 1 commit into from
Nov 12, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Nov 6, 2024 •
edited
Loading

Adds resizable columns and consistent sorting behavior to image list tables

This PR enhances the user experience of image list tables by:

  • Making columns resizable in both CustomizedImageList and ImageList components
  • Adding consistent sort directions (descend -> ascend -> descend) for sortable columns
  • Removing sorter tooltips for cleaner UI
  • Setting fixed initial width for image name columns based on screen size
  • Converting standard antd Tables to BAITable components for consistency

Screenshots:

image.png

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

To verify:

  1. Check that columns can be resized by dragging their borders
  2. Verify sort behavior cycles through: descending -> ascending -> descending
  3. Confirm image name columns have appropriate initial widths
  4. Ensure sorting works without tooltips appearing

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 6, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Nov 6, 2024
Merged
Merged
@agatha197 Graphite App
Copy link
Contributor Author

agatha197 commented Nov 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

This was referenced Nov 6, 2024
Merged
Merged
@github-actions github-actions bot added the size:S 10~30 LoC label Nov 6, 2024
@agatha197 agatha197 added urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. type:refactor Refactoring current implementation. labels Nov 6, 2024 — with Graphite App
@agatha197 agatha197 added this to the 24.09 milestone Nov 6, 2024
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from cb457a2 to c95f3bb Compare November 6, 2024 07:42
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 42f1633 to 01f85fa Compare November 6, 2024 07:42
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from c95f3bb to a0eef13 Compare November 6, 2024 07:54
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 01f85fa to 9f011d1 Compare November 6, 2024 07:54
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from a0eef13 to 75be312 Compare November 6, 2024 08:01
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 9f011d1 to 0ba3ce2 Compare November 6, 2024 08:01
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 75be312 to 41e7bf3 Compare November 7, 2024 05:31
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 0ba3ce2 to c089603 Compare November 7, 2024 05:32
@yomybaby yomybaby force-pushed the feature/add-image-util-functions-test branch from 41e7bf3 to d0da32f Compare November 7, 2024 09:04
@yomybaby yomybaby force-pushed the feature/make-image-lists-resizable branch from c089603 to 8fb21cb Compare November 7, 2024 09:04
@yomybaby yomybaby mentioned this pull request Nov 7, 2024
Merged
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from d0da32f to ff086a3 Compare November 11, 2024 00:55
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 8fb21cb to 679c83c Compare November 11, 2024 00:55
ironAiken2
ironAiken2 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from ff086a3 to 52c9cdc Compare November 11, 2024 05:26
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 679c83c to f4f3b30 Compare November 11, 2024 05:26
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 52c9cdc to 8a150e9 Compare November 11, 2024 05:29
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from f4f3b30 to 7f6502f Compare November 11, 2024 05:29
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 8a150e9 to 882b8e0 Compare November 12, 2024 07:52
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 7f6502f to 8c89ece Compare November 12, 2024 07:52
@agatha197 agatha197 mentioned this pull request Nov 12, 2024
Merged
4 tasks
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 882b8e0 to 4717484 Compare November 12, 2024 08:24
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 8c89ece to 4b7ae74 Compare November 12, 2024 08:24
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 4717484 to 5d06299 Compare November 12, 2024 08:32
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 4b7ae74 to 0a90887 Compare November 12, 2024 08:32
@agatha197 agatha197 force-pushed the feature/add-image-util-functions-test branch from 5d06299 to a59e849 Compare November 12, 2024 08:36
@agatha197 agatha197 force-pushed the feature/make-image-lists-resizable branch from 0a90887 to 64a56cd Compare November 12, 2024 08:36
@yomybaby yomybaby force-pushed the feature/make-image-lists-resizable branch from 64a56cd to 482c0ac Compare November 12, 2024 08:45
@yomybaby yomybaby changed the base branch from feature/add-image-util-functions-test to refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 November 12, 2024 08:45
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 12, 2024 •
edited
Loading

Merge activity

@agatha197
feat: make image lists resizable (#2823)
506a1a1 
Adds resizable columns and consistent sorting behavior to image list tables

This PR enhances the user experience of image list tables by:
- Making columns resizable in both CustomizedImageList and ImageList components
- Adding consistent sort directions (descend -> ascend -> descend) for sortable columns
- Removing sorter tooltips for cleaner UI
- Setting fixed initial width for image name columns based on screen size
- Converting standard antd Tables to BAITable components for consistency

**Screenshots:**

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/53c64bff-61e1-4d9d-adf8-c95a0abdae83.png)

**Checklist:**

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

To verify:
1. Check that columns can be resized by dragging their borders
2. Verify sort behavior cycles through: descending -> ascending -> descending
3. Confirm image name columns have appropriate initial widths
4. Ensure sorting works without tooltips appearing
@yomybaby yomybaby force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 983a8a6 to 5e898eb Compare November 12, 2024 08:55
@yomybaby yomybaby force-pushed the feature/make-image-lists-resizable branch from 482c0ac to 506a1a1 Compare November 12, 2024 08:56
Base automatically changed from refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 to main November 12, 2024 08:59
@graphite-app graphite-app bot merged commit 506a1a1 into main Nov 12, 2024
4 checks passed
@graphite-app graphite-app bot deleted the feature/make-image-lists-resizable branch November 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironAiken2 ironAiken2 ironAiken2 approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@agatha197 agatha197

Labels
size:S 10~30 LoC type:refactor Refactoring current implementation. urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
24.09
Development

Successfully merging this pull request may close these issues.
2 participants
@agatha197 @ironAiken2