Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FR-242): show vfolder list based on delegated user #3070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Jan 23, 2025

resolves #3017 (FR-242)

The ability to create a session by setting a Session Owner is not currently available. https://lablup.atlassian.net/browse/BA-414
In this PR, I'm aiming to show the right vfolder list for the set session owner.

In the VFolderTable used by the session launcher, we are fetching the vfolder list via the REST API. Since the API provides the ability to filter the data based on owner email, use it to show the vfolder list based on the delegated owner email assigned by the session launcher.

feature:

  • If owner is set in the session launcher, it will show a list of vfolders for that user.
  • If a previously selected vfolder exists, all selections will be reset when the owner related settings are changed.

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:S 10~30 LoC label Jan 23, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 23, 2025

Coverage report for ./react

Action wasn't able to generate report within GitHub comment limit. If you're facing this issue, please let me know by commenting under this issue.

Report generated by 🧪jest coverage report action from 889564c

@ironAiken2 ironAiken2 changed the title fix: show vfolder list based on delegated user fix(FR-242): show vfolder list based on delegated user Jan 23, 2025
@ironAiken2 ironAiken2 marked this pull request as ready for review January 23, 2025 09:46
@ironAiken2 ironAiken2 force-pushed the fix/show-vfolder-list-based-on-delegated-user branch from 315d315 to 05ea0ba Compare January 31, 2025 04:07
@ironAiken2 ironAiken2 requested a review from yomybaby January 31, 2025 04:09
@ironAiken2 ironAiken2 force-pushed the fix/show-vfolder-list-based-on-delegated-user branch from 05ea0ba to fc85aa4 Compare February 14, 2025 08:45
@ironAiken2 ironAiken2 force-pushed the fix/show-vfolder-list-based-on-delegated-user branch 3 times, most recently from 26f03eb to f622330 Compare March 4, 2025 02:03
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve lint error:

/home/runner/work/backend.ai-webui/backend.ai-webui/react/src/App.tsx
Warning:   198:23  warning  't' is assigned a value but never used  @typescript-eslint/no-unused-vars

Copy link
Contributor Author

Just fixed.

@ironAiken2 ironAiken2 force-pushed the fix/show-vfolder-list-based-on-delegated-user branch from f622330 to 2ad58c9 Compare March 4, 2025 04:03
@ironAiken2 ironAiken2 requested a review from yomybaby March 4, 2025 04:03
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's necessary to refactor overall related to the separation of concerns. Let's discuss this end of the this week.

@ironAiken2 ironAiken2 changed the title fix(FR-242): show vfolder list based on delegated user fix(FR-376): show vfolder list based on delegated user Mar 4, 2025
@ironAiken2 ironAiken2 changed the title fix(FR-376): show vfolder list based on delegated user fix(FR-242): show vfolder list based on delegated user Mar 4, 2025
@ironAiken2 ironAiken2 force-pushed the fix/show-vfolder-list-based-on-delegated-user branch from 2ad58c9 to 889564c Compare March 11, 2025 04:34
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Mar 11, 2025
@ironAiken2 ironAiken2 requested a review from yomybaby March 11, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's add max_pending_session_count, max_concurrent_sftp_sessions to keypair resource policy.
2 participants