Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-55): Support ai.backend.accelerators image label's * value #3089

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

disable preset based on supported_accelerators

1cd4b5b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

feat(FR-55): Support ai.backend.accelerators image label's * value #3089

disable preset based on supported_accelerators
1cd4b5b
Select commit
Loading
Failed to load commit list.
GitHub Actions / Tests annotations (🧪 jest-coverage-report-action) failed Feb 3, 2025 in 0s

Test suite run failed

Failed tests: 4/124. Failed suites: 1/14.

Details

Created failed tests' annotations. To disable them, see documentation.

  ● getAllocatablePresetNames › should return presets when currentImage has accelerator limits

    expect(received).toEqual(expected) // deep equality

    - Expected  - 3
    + Received  + 1

    - Array [
    -   "cuda_shares_prest_1",
    - ]
    + Array []

      61 |     );
      62 |     //  must compare the preset's resource slots with the resource limits even `check-preset` result has allocatable.
    > 63 |     expect(result).toEqual(['cuda_shares_prest_1']);
         |                    ^
      64 |   });
      65 |
      66 |   it('should return empty array when no presets match', () => {

      at Object.<anonymous> (src/components/ResourceAllocationFormItems.test.ts:63:20)

  ● getAllocatablePresetNames › should handle empty resourceLimits

    expect(received).toEqual(expected) // deep equality

    - Expected  - 4
    + Received  + 1

    - Array [
    -   "cuda_shares_prest_10",
    -   "cuda_shares_prest_1",
    - ]
    + Array []

      101 |     );
      102 |     // Only presets that have cuda.shares minimum 1 should be returned.
    > 103 |     expect(result).toEqual(['cuda_shares_prest_10', 'cuda_shares_prest_1']);
          |                    ^
      104 |   });
      105 |
      106 |   it('should handle empty image', () => {

      at Object.<anonymous> (src/components/ResourceAllocationFormItems.test.ts:103:20)

  ● getAllocatablePresetNames › should handle empty image

    expect(received).toEqual(expected) // deep equality

    - Expected  - 4
    + Received  + 1

    - Array [
    -   "cuda_shares_prest_1",
    -   "cpu1_mem2g",
    - ]
    + Array []

      111 |     );
      112 |     // Only compare with resource limits
    > 113 |     expect(result).toEqual(['cuda_shares_prest_1', 'cpu1_mem2g']);
          |                    ^
      114 |   });
      115 |
      116 |   it('should handle empty image and small mem limit', () => {

      at Object.<anonymous> (src/components/ResourceAllocationFormItems.test.ts:113:20)

  ● getAllocatablePresetNames › should handle empty image and small mem limit

    expect(received).toEqual(expected) // deep equality

    - Expected  - 3
    + Received  + 1

    - Array [
    -   "cpu1_mem2g",
    - ]
    + Array []

      124 |     );
      125 |     // Only compare with resource limits
    > 126 |     expect(result).toEqual(['cpu1_mem2g']);
          |                    ^
      127 |   });
      128 | });
      129 |

      at Object.<anonymous> (src/components/ResourceAllocationFormItems.test.ts:126:20)

Annotations

Check failure on line 56 in react/src/components/ResourceAllocationFormItems.test.ts

See this annotation in the file changed.

@github-actions github-actions / Tests annotations (🧪 jest-coverage-report-action)

getAllocatablePresetNames > should return presets when currentImage has accelerator limits 

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 3
+ Received  + 1

- Array [
-   "cuda_shares_prest_1",
- ]
+ Array []
    at Object.<anonymous> (/home/runner/work/backend.ai-webui/backend.ai-webui/react/src/components/ResourceAllocationFormItems.test.ts:63:20)
    at Promise.then.completed (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:60:9)
    at run (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/testWorker.js:133:12)

Check failure on line 92 in react/src/components/ResourceAllocationFormItems.test.ts

See this annotation in the file changed.

@github-actions github-actions / Tests annotations (🧪 jest-coverage-report-action)

getAllocatablePresetNames > should handle empty resourceLimits 

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 4
+ Received  + 1

- Array [
-   "cuda_shares_prest_10",
-   "cuda_shares_prest_1",
- ]
+ Array []
    at Object.<anonymous> (/home/runner/work/backend.ai-webui/backend.ai-webui/react/src/components/ResourceAllocationFormItems.test.ts:103:20)
    at Promise.then.completed (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:60:9)
    at run (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/testWorker.js:133:12)

Check failure on line 106 in react/src/components/ResourceAllocationFormItems.test.ts

See this annotation in the file changed.

@github-actions github-actions / Tests annotations (🧪 jest-coverage-report-action)

getAllocatablePresetNames > should handle empty image 

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 4
+ Received  + 1

- Array [
-   "cuda_shares_prest_1",
-   "cpu1_mem2g",
- ]
+ Array []
    at Object.<anonymous> (/home/runner/work/backend.ai-webui/backend.ai-webui/react/src/components/ResourceAllocationFormItems.test.ts:113:20)
    at Promise.then.completed (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:60:9)
    at run (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/testWorker.js:133:12)

Check failure on line 116 in react/src/components/ResourceAllocationFormItems.test.ts

See this annotation in the file changed.

@github-actions github-actions / Tests annotations (🧪 jest-coverage-report-action)

getAllocatablePresetNames > should handle empty image and small mem limit 

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 3
+ Received  + 1

- Array [
-   "cpu1_mem2g",
- ]
+ Array []
    at Object.<anonymous> (/home/runner/work/backend.ai-webui/backend.ai-webui/react/src/components/ResourceAllocationFormItems.test.ts:126:20)
    at Promise.then.completed (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:60:9)
    at run (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/home/runner/work/backend.ai-webui/backend.ai-webui/react/node_modules/.pnpm/[email protected]/node_modules/jest-runner/build/testWorker.js:133:12)
View more details on GitHub Actions