Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FR-484): refactor statistics page to react component #3178

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Feb 17, 2025

resolves #3120(FR-484)

chages

  • add new hook useUserStats for userStats using useSuspenseQuery
  • add antd/charts package to use antd's charts
  • add tooltip to each items
스크린샷 2025-03-05 오후 2 46 11

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

Coverage report for ./react

Action wasn't able to generate report within GitHub comment limit. If you're facing this issue, please let me know by commenting under this issue.

Report generated by 🧪jest coverage report action from 7fa9844

@nowgnuesLee nowgnuesLee marked this pull request as ready for review March 4, 2025 04:31
@nowgnuesLee nowgnuesLee requested review from yomybaby and lizable March 4, 2025 04:31
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add a tooltip to each graph title instead of previous information modal.

image.png

  1. Add "Period" to a period Select.

  2. Use column chart instead of line chart.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflict and add Jira number to PR title.

@nowgnuesLee nowgnuesLee changed the title refactor: refactor statistics page to react component refactor(FR-484): refactor statistics page to react component Mar 5, 2025
@nowgnuesLee nowgnuesLee requested a review from yomybaby March 5, 2025 05:50
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the following points for refactoring and then request a re-review:

  • Readability: The return JSX of a component should be clear enough to understand its structure. Over-componentization or excessive hook development can reduce readability.
  • Separation of Concerns: Ensure that components or functions contain only their specific concerns, such as data fetching or transforming data for a specific component.

@nowgnuesLee nowgnuesLee force-pushed the refactor/statistics-react branch from 7fa9844 to 41829e3 Compare March 11, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migratie Statistics page to React
2 participants