Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BA-941): clean up unused configuration of webserver.conf #3934

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Mar 10, 2025

resolves #nnn (BA-941)

Related PR : lablup/backend.ai-webui#3325

Removes unused configuration options from the web server:

  • Removes brand field from UI section
  • Removes enable_model_store from service section
  • Removes enable_LLM_playground from UI section

Checklist:

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--3934.org.readthedocs.build/en/3934/


📚 Documentation preview 📚: https://sorna-ko--3934.org.readthedocs.build/ko/3934/

@github-actions github-actions bot added size:S 10~30 LoC area:docs Documentations comp:webserver Related to Web Server component labels Mar 10, 2025
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 changed the title chore: clean up unused configuration of webserver.conf chore(BA-941): clean up unused configuration of webserver.conf Mar 10, 2025
@ironAiken2 ironAiken2 marked this pull request as ready for review March 10, 2025 09:12
@Copilot Copilot bot review requested due to automatic review settings March 10, 2025 09:12
@ironAiken2 ironAiken2 force-pushed the chore/clean-up-webserver-configuration branch from b10df13 to 4dec006 Compare March 11, 2025 04:40
@HyeockJinKim HyeockJinKim added the skip:changelog Make the action workflow to skip towncrier check label Mar 11, 2025
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit efe161a Mar 11, 2025
24 of 26 checks passed
@HyeockJinKim HyeockJinKim deleted the chore/clean-up-webserver-configuration branch March 11, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:webserver Related to Web Server component size:S 10~30 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants