Repository navigation
Conversation
lacatoire
force-pushed
the
chore/generated-files-in-temp
branch
from
August 7, 2026 12:28
2609b9c to
5016f3e
Compare
lacatoire
changed the title
lacatoire
force-pushed
the
chore/generated-files-in-temp
branch
from
August 7, 2026 12:31
5016f3e to
4bf9e75
Compare
doc-base is moving every file its build generates into a temp/ subdirectory, the manual file included. xmlRoot is the directory of the file passed to -d, so it gains one level, and dirname($config->xmlRoot) stops pointing at the directory holding the language checkouts: the acronym entity file is then not found and expansions are silently skipped. The lookup now goes through $docsRoot, so the day doc-base moves, only that line changes. The documented command line is updated as well.
lacatoire
changed the title
lacatoire
force-pushed
the
chore/generated-files-in-temp
branch
from
August 7, 2026 12:45
4bf9e75 to
8b4baba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc-baseis moving every file its build generates into a single ignoredtemp/directory, the manual file included.The three generated files it feeds PhD need no change:
xmlRootisdirname()of the path given to-d(phpdotnet/phd/Options/Handler.php:193), so pointing-datdoc-base/temp/.manual.xmlresolvesversion.xml,sources.xmlandfileModHistory.phpinsidetemp/on their own.The acronym lookup does break, though. It walks up from
xmlRootto reach the language checkouts sitting next todoc-base, and that path gains one level:The warning is
Can't find acronym file (...), skipping, so acronym expansions would quietly disappear from the rendered manual.The lookup now goes through a
$docsRootvariable holding today's value. When the doc-base side is merged it becomesdirname(dirname($config->xmlRoot))and nothing else moves. Verified both ways with a full-f phprender: the warning appears with one and is gone with the other.