Skip to content

ci(l1): comment flaky snap sync test #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

ci(l1): comment flaky snap sync test #2672

merged 1 commit into from
May 13, 2025

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented May 6, 2025

Motivation

  • Test is flaky in CI

Description

Closes #issue_number

@JereSalo JereSalo self-assigned this May 6, 2025
@JereSalo JereSalo added the ci Github actions, build, tests, etc label May 6, 2025
@JereSalo JereSalo closed this May 12, 2025
@JereSalo JereSalo reopened this May 13, 2025
@JereSalo JereSalo marked this pull request as ready for review May 13, 2025 15:09
@JereSalo JereSalo requested a review from a team as a code owner May 13, 2025 15:09
@github-actions GitHub Actions
Copy link

Lines of code report

Total lines added: 2380
Total lines removed: 612
Total lines changed: 2992

Detailed view 
+------------------------------------------------------------------------+-------+------+
| File                                                                   | Lines | Diff |
+------------------------------------------------------------------------+-------+------+
| ethrex/bench/criterion_benchmark.rs                                    | 34    | +34  |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ef_tests/state/parser.rs                                    | 157   | -3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ef_tests/state/report.rs                                    | 822   | +36  |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ef_tests/state/runner/mod.rs                                | 231   | -7   |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs                                      | 379   | +9   |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/l2.rs                                                | 256   | +256 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs                                 | 494   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/mempool.rs                                    | 571   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/smoke_test.rs                                 | 235   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/node_hash.rs                                 | 129   | +2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/common/types/blobs_bundle.rs                             | 324   | -2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/common/types/block.rs                                    | 713   | -3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/common/types/transaction.rs                              | 2504  | +1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/common/types/tx_fields.rs                                | 58    | +1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/contracts/deployer.rs                                 | 804   | +804 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/contracts/system_contracts_updater.rs                 | 56    | +56  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/contracts/utils.rs                                    | 66    | +66  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/l2.rs                                                 | 4     | -4   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/bench/src/main.rs                              | 95    | -33  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/bench/src/rpc/db.rs                            | 489   | +1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/backends/exec.rs                           | 81    | -22  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/prover.rs                                  | 119   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/pico/src/main.rs                | 63    | -23  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/risc0/src/main.rs               | 69    | -15  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/sp1/src/main.rs                 | 70    | -25  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/src/lib.rs                      | 193   | -87  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sdk/src/sdk.rs                                        | 214   | -199 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/block_producer.rs                           | 111   | -12  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/block_producer/payload_builder.rs           | 227   | +2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/errors.rs                                   | 197   | -12  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_committer.rs                             | 509   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_proof_sender.rs                          | 165   | +2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_watcher.rs                               | 301   | +5   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/metrics.rs                                  | 81    | +6   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/mod.rs                                      | 65    | -6   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/proof_coordinator.rs                        | 297   | -6   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/block_producer.rs                        | 18    | +18  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/committer.rs                             | 25    | +25  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/eth.rs                                   | 18    | +18  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/l1_watcher.rs                            | 23    | +23  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/mod.rs                                   | 126   | +43  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/proof_coordinator.rs                     | 26    | +26  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/config/toml_parser.rs                           | 269   | +189 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/error.rs                                        | 22    | -3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/prover/save_state.rs                            | 425   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/test_data_io.rs                                 | 87    | -3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/discv4/server.rs                          | 682   | -3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/admin/mod.rs                              | 58    | +4   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/clients/eth/mod.rs                        | 1099  | -16  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/engine/fork_choice.rs                     | 393   | +4   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/engine/payload.rs                         | 729   | +5   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/eth/fee_market.rs                         | 234   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/eth/max_priority_fee.rs                   | 130   | +34  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/rpc.rs                                    | 647   | +23  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/utils.rs                                  | 413   | -2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/storage/lib.rs                                           | 12    | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/redb.rs                                 | 1218  | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/backends/levm/mod.rs                                  | 640   | -3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/backends/mod.rs                                       | 235   | -9   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/backends/revm/mod.rs                                  | 593   | -45  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/call_frame.rs                                | 128   | -5   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/db/gen_db.rs                                 | 188   | -12  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/execution_handlers.rs                        | 233   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/gas_cost.rs                                  | 1131  | +264 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/hooks/default_hook.rs                        | 339   | +4   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/hooks/l2_hook.rs                             | 133   | -3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/lib.rs                                       | 16    | +1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/arithmetic.rs                | 218   | +1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/bitwise_comparison.rs        | 301   | +12  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/block.rs                     | 140   | +14  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/environment.rs               | 315   | +11  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/push.rs                      | 59    | +17  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/stack_memory_storage_flow.rs | 287   | +17  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/system.rs                    | 842   | +52  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/operations.rs                                | 239   | +239 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/precompiles.rs                               | 1407  | +40  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/utils.rs                                     | 426   | +15  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/vm.rs                                        | 386   | -39  |
+------------------------------------------------------------------------+-------+------+

@mpaulucci mpaulucci enabled auto-merge May 13, 2025 15:32
@lambdaclass lambdaclass deleted a comment from JereSalo May 13, 2025
fedacking
fedacking approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@fedacking fedacking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpaulucci mpaulucci added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit 37498c6 May 13, 2025
39 of 43 checks passed
@mpaulucci mpaulucci deleted the flaky-snap-test branch May 13, 2025 16:02
fmoletta pushed a commit that referenced this pull request May 15, 2025
@JereSalo @fmoletta
ci(l1): comment flaky snap sync test (#2672)
1d70c9e 
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->
- Test is flaky in CI

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #issue_number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@fedacking fedacking fedacking approved these changes

Assignees

@JereSalo JereSalo

Labels
ci Github actions, build, tests, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JereSalo @mpaulucci @fedacking