Skip to content

fix(l2): remove fork as parameter in get_state_transitions function #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

fix(l2): remove fork as parameter in get_state_transitions function #2723

merged 2 commits into from
May 12, 2025

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented May 8, 2025 •
edited
Loading

In this PR we forgot to remove fork from some places in which get_state_transitions was being used.

We should try to find a way to fix rust-analyzer so that it detects those cases but I don't know how hard it is.

@JereSalo JereSalo marked this pull request as ready for review May 8, 2025 21:54
@JereSalo JereSalo requested a review from a team as a code owner May 8, 2025 21:54
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2025

Lines of code report

Total lines added: 0
Total lines removed: 4
Total lines changed: 4

Detailed view 
+----------------------------------------------------------+-------+------+
| File                                                     | Lines | Diff |
+----------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/bench/src/rpc/db.rs              | 488   | -1   |
+----------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/pico/src/main.rs  | 62    | -1   |
+----------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/risc0/src/main.rs | 68    | -1   |
+----------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/sp1/src/main.rs   | 69    | -1   |
+----------------------------------------------------------+-------+------+

LeanSerra
LeanSerra approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@LeanSerra LeanSerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@fmoletta fmoletta added this pull request to the merge queue May 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 9, 2025
@LeanSerra LeanSerra enabled auto-merge May 12, 2025 14:10
@LeanSerra LeanSerra added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 12, 2025
@LeanSerra LeanSerra added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit 9c9fd92 May 12, 2025
14 checks passed
@LeanSerra LeanSerra deleted the fix-bug-forks branch May 12, 2025 16:20
fmoletta pushed a commit that referenced this pull request May 15, 2025
@JereSalo @fmoletta
fix(l2): remove fork as parameter in get_state_transitions function (#…
d48b627 
…2723)

In [this
PR](a5da369)
we forgot to remove fork from some places in which get_state_transitions
was being used.

We should try to find a way to fix rust-analyzer so that it detects
those cases but I don't know how hard it is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@LeanSerra LeanSerra LeanSerra approved these changes

@fmoletta fmoletta fmoletta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JereSalo @mpaulucci @LeanSerra @fmoletta