refactor(l1): spawned p2p #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
| pub(crate) init_message: Vec<u8>, | ||
| } | ||
|
|
||
| pub(crate) async fn perform( |
There was a problem hiding this comment.
I find the name "perform" a bit confusing, can we add some comments on what this function does?
There was a problem hiding this comment.
Ah, I see, "perform" as in "perform handshake", a little bit confusing without context still
There was a problem hiding this comment.
Yeah... is to be used in the form handshake::perform but will think if there's a more expressive way
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
| pub(crate) stream: Arc<TcpStream>, | ||
| } | ||
|
|
||
| #[derive(Clone)] |
There was a problem hiding this comment.
Does this struct really need Clone? The original RLPxConnection didn't need to be cloned, also if we're clonning an 'established' connection somewhere, I'm guessing we're doing something wrong.
There was a problem hiding this comment.
Yes, as it is part of the State of a GenServer. We may be cloning the state, but not the connection itself (which is a single spawned task)
fkrause98
reviewed
Jul 2, 2025
fkrause98
reviewed
Jul 2, 2025
fkrause98
approved these changes
Jul 2, 2025
Arkenan
approved these changes
Jul 3, 2025
| } | ||
|
|
||
| impl GenServer for RLPxConnection { | ||
| type CallMsg = Unused; |
There was a problem hiding this comment.
Nit: If we have unused here, do we need to define the empty call message struct above?
There was a problem hiding this comment.
Not really, good find. Don't know why rust forgot to complain about an unused struct.
d-roak
pushed a commit
to 1sixtech/ethrex
that referenced
this pull request
Jul 17, 2025
P2p connection processes are complex and error prone. Using `spawned` to clean it up and properly separate concurrency logic from business logic. **Description** Replaces the main_loop from `RLPxConnection` with a `spawned` process that handles all the messages from and to the remote peer, as well as the backend. --------- Co-authored-by: Lucas Fiegl <[email protected]> Co-authored-by: Tomás Grüner <[email protected]> Co-authored-by: Manuel Iñaki Bilbao <[email protected]> Co-authored-by: Avila Gastón <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: Jeremías Salomón <[email protected]> Co-authored-by: Mario Rugiero <[email protected]> Co-authored-by: MrAzteca <[email protected]> Co-authored-by: Edgar <[email protected]> Co-authored-by: LeanSerra <[email protected]>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
P2p connection processes are complex and error prone. Using `spawned` to clean it up and properly separate concurrency logic from business logic. **Description** Replaces the main_loop from `RLPxConnection` with a `spawned` process that handles all the messages from and to the remote peer, as well as the backend. --------- Co-authored-by: Lucas Fiegl <[email protected]> Co-authored-by: Tomás Grüner <[email protected]> Co-authored-by: Manuel Iñaki Bilbao <[email protected]> Co-authored-by: Avila Gastón <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: Jeremías Salomón <[email protected]> Co-authored-by: Mario Rugiero <[email protected]> Co-authored-by: MrAzteca <[email protected]> Co-authored-by: Edgar <[email protected]> Co-authored-by: LeanSerra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2p connection processes are complex and error prone. Using
spawnedto clean it up and properly separate concurrency logic from business logic.Description
Replaces the main_loop from
RLPxConnectionwith aspawnedprocess that handles all the messages from and to the remote peer, as well as the backend.