chore(l2): rename estimate_gas error #3225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avilagaston9
changed the title
avilagaston9
changed the title
Lines of code reportTotal lines added: Detailed view |
There was a problem hiding this comment.
Pull Request Overview
This PR renames the EstimateGasPriceError type to EstimateGasError for consistency with the estimate_gas method.
- Updated import statements and error mappings in
EthClient::estimate_gas - Renamed the
EstimateGasPriceErrorenum toEstimateGasError - Adjusted the
EthClientErrorvariant to wrap the newEstimateGasError
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/networking/rpc/clients/eth/mod.rs | Switched from EstimateGasPriceError to EstimateGasError in imports and in the estimate_gas flow |
| crates/networking/rpc/clients/eth/errors.rs | Renamed the EstimateGasPriceError enum to EstimateGasError and updated its registration in EthClientError |
Comments suppressed due to low confidence (2)
crates/networking/rpc/clients/eth/errors.rs:70
- [nitpick] Add a doc comment to
EstimateGasErrorexplaining the purpose of each variant (e.g., JSON deserialization failure, parse error, RPC error) to improve clarity for maintainers.
pub enum EstimateGasError {
crates/networking/rpc/clients/eth/errors.rs:70
- There aren’t existing tests covering the renamed
EstimateGasErrorvariants; consider adding unit tests for the serde, parse, and RPC error branches to prevent regressions.
pub enum EstimateGasError {
tomip01
approved these changes
Jun 19, 2025
jrchatruc
approved these changes
Jun 19, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** `EstimateGasPriceError` is actually an error triggered in `estimate_gas`. **Description** Renames `EstimateGasPriceError` to `EstimateGasError` Closes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EstimateGasPriceErroris actually an error triggered inestimate_gas.Description
Renames
EstimateGasPriceErrortoEstimateGasErrorCloses None