feat(l1): add From for Transaction -> GenericTransaction #3227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sacha Froment <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces conversion implementations to create a GenericTransaction from various Transaction types and adds initial unit tests for two of those conversions.
- Implemented
From<LegacyTransaction>andFrom<EIP2930Transaction>forGenericTransaction. - Added a blanket
From<Transaction>implementation covering all enum variants. - Added unit tests for
LegacyTransactionandEIP2930Transactionconversions.
Comments suppressed due to low confidence (1)
crates/common/types/transaction.rs:2971
- Only
LegacyTransactionandEIP2930Transactionconversions are tested. Add tests forEIP1559Transaction,EIP4844Transaction,EIP7702Transaction, andPrivilegedL2Transactionconversions to ensure full coverage.
fn test_legacy_transaction_into_generic() {
sfroment
changed the title
mpaulucci
changed the title
mpaulucci
approved these changes
Jul 14, 2025
d-roak
pushed a commit
to 1sixtech/ethrex
that referenced
this pull request
Jul 17, 2025
…#3227) **Motivation** Adding an easy way to get a GenericTransaction from any Transaction <!-- Why does this pull request exist? What are its goals? --> **Description** Adding the 2 missing From and one for the enum This will allow people who use the ethClient to make estimate_gas and eth_call request, more easily and maybe other request in the future might benefit from it <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> BTW I don't know which scope I shall use Signed-off-by: Sacha Froment <[email protected]> Co-authored-by: Martin Paulucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding an easy way to get a GenericTransaction from any Transaction
Description
Adding the 2 missing From and one for the enum
This will allow people who use the ethClient to make estimate_gas and eth_call request, more easily and maybe other request in the future might benefit from it
BTW I don't know which scope I shall use