feat(l1): add "eth" entry to local ENR #5372
Closed
+210
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshya-sky
changed the title
Signed-off-by: lakshya-sky <[email protected]>
lakshya-sky
force-pushed
the
feature/add-eth-entry-in-enr
branch
from
ce9a937 to
647bce1
Compare
lakshya-sky
changed the title
* make storage variables as explicitly unused. * add note for sorting the keys. Signed-off-by: lakshya-sky <[email protected]>
MegaRedHand
requested changes
Nov 27, 2025
| pub tcp_port: Option<u16>, | ||
| pub udp_port: Option<u16>, | ||
| pub secp256k1: Option<H264>, | ||
| pub snap: Option<Vec<(Bytes, Bytes)>>, |
Collaborator
There was a problem hiding this comment.
I can't find a "snap" entry in the spec. Could you link to where you found it?
| structs::Encoder::new(&mut rlp) | ||
| .encode_field(&self.seq) | ||
| .encode_key_value_list::<Bytes>(&self.pairs) | ||
| .encode_key_value_list::<Bytes>(&self.pairs.encode_pairs()) |
|
|
||
| impl NodeRecord { | ||
| pub fn decode_pairs(&self) -> NodeRecordPairs { | ||
| impl NodeRecordPairs { |
Collaborator
There was a problem hiding this comment.
Why was this implementation switched with NodeRecord?
Contributor
Author
|
Hey @MegaRedHand , I have made changes for another issue(#5068) in the current PR. I will close this and raise new PRs for each issues separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Geth uses forkId for making connection as outlined in this post https://ethereum-magicians.org/t/all-core-devs-testing-acdt-46-july-28-2025/24889/6 and ethereum/go-ethereum#31944.
Description
Closes #5066