Skip to content

Conversation

@mpaulucci
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings November 18, 2025 14:30
@mpaulucci mpaulucci requested a review from a team as a code owner November 18, 2025 14:30
@mpaulucci mpaulucci enabled auto-merge November 18, 2025 14:30
@github-actions github-actions bot added the L1 Ethereum client label Nov 18, 2025
Copilot finished reviewing on behalf of mpaulucci November 18, 2025 14:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unnecessary info-level log statement from the get_transaction_by_hash function that was logging every transaction hash lookup. This type of verbose logging can clutter logs in production environments, especially for frequently called operations.

Key Changes

  • Removed info! macro call that logged transaction hash lookups in the get_transaction_by_hash method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Lines of code report

Total lines added: 0
Total lines removed: 4
Total lines changed: 4

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs | 1590  | -4   |
+-------------------------------------------+-------+------+

@mpaulucci mpaulucci added this pull request to the merge queue Nov 19, 2025
@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Nov 19, 2025
Merged via the queue into main with commit 82d4ead Nov 19, 2025
50 checks passed
@mpaulucci mpaulucci deleted the remove-tx-log branch November 19, 2025 11:12
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants