fix(l2): fix block execution with SP1 #5542
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a gas mismatch error when executing blocks with SP1 by conditionally handling the type conversion in the bn254_g1_mul precompile. The issue was introduced by PR #5529, which unified the behavior across SP1 and ZisK but inadvertently changed SP1's multiplication semantics.
Key Changes:
- Modified the
bn254_g1_mulfunction to only convertAffineG1toG1when theziskfeature is enabled - For SP1, the point remains as
AffineG1during scalar multiplication to preserve correct gas calculation behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let g1 = AffineG1::new(g1_x, g1_y) | ||
| .map_err(|_| PrecompileError::InvalidPoint)?; | ||
|
|
||
| // Small difference between the patched versions of substrate-bn |
There was a problem hiding this comment.
The comment should explain WHY this conditional conversion is needed and what the actual difference is between the SP1 and ZisK substrate-bn patches. Consider expanding it to something like:
// SP1's substrate-bn patch implements multiplication for AffineG1 * Fr differently
// than ZisK's patch. For ZisK, we need to convert to G1 first, while SP1 requires
// AffineG1 to avoid gas mismatch issues (e.g., block 23919500 from Mainnet).This would help future maintainers understand the reasoning behind this platform-specific behavior.
Suggested change
| // Small difference between the patched versions of substrate-bn | |
| // SP1's substrate-bn patch implements multiplication for AffineG1 * Fr differently | |
| // than ZisK's patch. For ZisK, we need to convert to G1 first, while SP1 requires | |
| // AffineG1 to avoid gas mismatch issues (e.g., block 23919500 from Mainnet). |
Lines of code reportTotal lines added: Detailed view |
ilitteri
approved these changes
Dec 5, 2025
Benchmark Results ComparisonNo significant difference was registered for any benchmark run. Detailed ResultsBenchmark Results: BubbleSort
Benchmark Results: ERC20Approval
Benchmark Results: ERC20Mint
Benchmark Results: ERC20Transfer
Benchmark Results: Factorial
Benchmark Results: FactorialRecursive
Benchmark Results: Fibonacci
Benchmark Results: FibonacciRecursive
Benchmark Results: ManyHashes
Benchmark Results: MstoreBench
Benchmark Results: Push
Benchmark Results: SstoreBench_no_opt
|
JereSalo
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Execution with SP1 was failing after PR #5529 which changes a line of the
ecmulprecompile to make it compatible with an API difference between the substrate-bn patch of SP1 and ZisK.Apparently this also changes the behavior of the multiplication for the SP1 patch, and some blocks (like block 23919500 from Mainnet) were failing to execute due to a gas mismatch error.
Reverting the change for SP1 fixes the issue.