feat(l2): introduce FlatTrie as a zkVM performant MPT #5554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark for 595856aClick to view benchmark
|
Oppen
reviewed
Dec 9, 2025
| /// A leaf node doesn't have any childs | ||
| Leaf, | ||
| /// An extension node always has a branch as a child | ||
| Extension { child: Option<usize> }, |
Contributor
There was a problem hiding this comment.
Why is the child an option, if it's guaranteed to exist and be a branch?
Oppen
reviewed
Dec 9, 2025
| rkyv::Archive, | ||
| )] | ||
| pub enum NodeChilds { | ||
| /// A leaf node doesn't have any childs |
Contributor
There was a problem hiding this comment.
Suggested change
| /// A leaf node doesn't have any childs | |
| /// A leaf node doesn't have any children |
Oppen
reviewed
Dec 9, 2025
Comment on lines
+88
to
+91
| if let NodeRef::Node(child_node, _) = &node.child { | ||
| recursive(child_node, trie); | ||
| child = Some(trie.views.len() - 1); | ||
| } |
Contributor
There was a problem hiding this comment.
How can we tell when a given child is unpopulated from it just being in hashed form?
Oppen
reviewed
Dec 9, 2025
| }; | ||
|
|
||
| let offset = trie.data.len(); | ||
| trie.data.extend(value.encode_to_vec()); |
Contributor
There was a problem hiding this comment.
It's probably better to do:
Suggested change
| trie.data.extend(value.encode_to_vec()); | |
| value.encode(&mut trie.data); |
That should save a memcpy and a second realloc.
Oppen
reviewed
Dec 9, 2025
| /// Recursively traverses the trie, hashes each node's data and checks that their parents reference | ||
| /// those same hashes. This way the data gets authenticated. | ||
| /// | ||
| /// Initializes `Self::root_hash` if successful, and returns a boolean indicating success. |
Contributor
There was a problem hiding this comment.
Shouldn't auth failure be an error?
Benchmark for 6f9b9baClick to view benchmark
|
Benchmark for c42b68bClick to view benchmark
|
Benchmark for 51d2f20Click to view benchmark
|
Benchmark for 91bc7caClick to view benchmark
|
Benchmark for 31c08dfClick to view benchmark
|
Benchmark for ea76b6dClick to view benchmark
|
Benchmark for f8e1ec3Click to view benchmark
|
Benchmark Results ComparisonNo significant difference was registered for any benchmark run. Detailed ResultsBenchmark Results: BubbleSort
Benchmark Results: ERC20Approval
Benchmark Results: ERC20Mint
Benchmark Results: ERC20Transfer
Benchmark Results: Factorial
Benchmark Results: FactorialRecursive
Benchmark Results: Fibonacci
Benchmark Results: FibonacciRecursive
Benchmark Results: ManyHashes
Benchmark Results: MstoreBench
Benchmark Results: Push
Benchmark Results: SstoreBench_no_opt
|
Benchmark for 5e71131Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Checklist
STORE_SCHEMA_VERSION(crates/storage/lib.rs) if the PR includes breaking changes to theStorerequiring a re-sync.Closes #issue_number