fix(l1): revert commits back to 3797ce0 for syncing stability in sepolia #5556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8c8f758.
This reverts commit bce7bb1.
This reverts commit f450b6e.
This reverts commit 7722c65.
This reverts commit a67d5cf.
This reverts commit 4a3f3cf.
)" This reverts commit 8160d22.
This reverts commit b9bca06.
)" This reverts commit 823cf77.
This reverts commit e08d7e4.
This reverts commit 7fad543.
…)" This reverts commit 610df53.
Lines of code reportTotal lines added: Detailed view |
rodrigo-o
requested review from
a team,
ManuelBilbao,
avilagaston9,
ilitteri and
jrchatruc
as code owners
1 task
rodrigo-o
changed the title
Benchmark for 8d730adClick to view benchmark
|
MegaRedHand
approved these changes
Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts multiple commits (from 610df53 to HEAD) to restore the codebase to commit 3797ce0 in response to a regression discovered in the Sepolia syncing test. The revert affects multiple components including:
- Benchmark tooling: Simplifies the import benchmark script and removes directory management complexity
- L2 functionality: Removes shared bridge feature, including documentation, RLP message encoding for cross-L2 transfers, and balance diff tracking
- Storage layer: Removes database schema versioning system
- VM/LEVM: Removes ZISK-specific optimizations in precompiles and arithmetic operations
- Networking: Simplifies peer disconnection tracking and removes some verbose logging
- Documentation: Removes shared bridge guides and updates references from
MessengertoL2ToL1Messenger
Reviewed changes
Copilot reviewed 116 out of 133 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tooling/import_benchmark/parse_bench.py | Reverts to simpler file path handling using range-based indexing; contains spelling error |
| tooling/import_benchmark/benchmark.sh | Removes directory management logic and simplifies output paths |
| tooling/import_benchmark/README.md | Updates documentation to reflect simplified benchmark parameter handling |
| tooling/import_benchmark/Makefile | Updates help text to match new parameter format |
| tooling/archive_sync/src/main.rs | Removes unnecessary error handling wrapper |
| metrics/provisioning/grafana/dashboards/dashboard.yaml | Adds Grafana dashboard provisioning configuration |
| metrics/provisioning/grafana/dashboards/common_dashboards/ethrex_l1_perf.json | Removes "Peer Info" row from dashboard; adds hideSeriesFrom configuration |
| fixtures/genesis/l2.json | Updates L2 genesis contract bytecode |
| fixtures/blobs/8-1.blob | Adds binary blob test fixture |
| docs/l2/interacting/shared_bridge.md | Removes shared bridge interaction guide |
| docs/l2/interacting/README.md | Removes shared bridge reference |
| docs/l2/fundamentals/withdrawals.md | Updates messenger contract references to L2ToL1Messenger |
| docs/l2/fundamentals/shared_bridge.md | Removes shared bridge fundamentals documentation |
| docs/l2/fundamentals/contracts.md | Renames Messenger to L2ToL1Messenger |
| docs/l2/deployment/shared_bridge.md | Removes shared bridge deployment guide |
| docs/l2/deployment/migrations.md | Removes migration documentation |
| docs/l2/deployment/README.md | Removes shared bridge and migration references |
| docs/l1/running/monitoring.md | Removes note about ethereum-metrics-exporter dependency |
| docs/l1/fundamentals/databases.md | Removes database fundamentals documentation |
| docs/internal/l1/metrics_coverage_gap_analysis.md | Reverts peer health and error counter metrics status from "Partial" to "No" |
| docs/developers/l1/dashboards.md | Removes peer info dashboard section |
| docs/SUMMARY.md | Removes shared bridge, migrations, and database documentation links |
| crates/vm/levm/src/precompiles.rs | Removes ZISK feature flag conditionals; simplifies BN254 G1 multiplication |
| crates/vm/levm/src/opcode_handlers/arithmetic.rs | Removes ZISK-specific mulmod optimization |
| crates/vm/levm/Cargo.toml | Removes ziskos dependency |
| crates/storage/store_db/rocksdb.rs | Removes store schema version methods |
| crates/storage/store_db/in_memory.rs | Removes store schema version stub methods |
| crates/storage/store.rs | Removes schema version validation logic |
| crates/storage/lib.rs | Removes STORE_SCHEMA_VERSION constant |
| crates/storage/error.rs | Removes IncompatibleDBVersion error variant |
| crates/storage/api.rs | Removes schema version trait methods |
| crates/storage/Cargo.toml | Adds ethrex-trie/rocksdb feature dependency |
| crates/networking/p2p/sync/storage_healing.rs | Removes periodic "no free peers" logging throttling |
| crates/networking/p2p/sync/state_healing.rs | Removes periodic "no free peers" logging and sleep |
| crates/networking/p2p/rlpx/p2p.rs | Removes DisconnectReason::all() helper method and test |
| crates/networking/p2p/rlpx/l2/messages.rs | Removes l2_message_hashes and balance_diffs from Batch RLP encoding |
| crates/networking/p2p/rlpx/connection/server.rs | Moves disconnect metric recording from teardown to message handling; contains spelling error |
| crates/networking/p2p/rlpx/connection/handshake.rs | Removes disconnect_reason and is_validated state fields |
| crates/networking/p2p/peer_handler.rs | Removes periodic "no free peers" logging throttling across multiple request methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benchmark Results ComparisonNo significant difference was registered for any benchmark run. Detailed ResultsBenchmark Results: BubbleSort
Benchmark Results: ERC20Approval
Benchmark Results: ERC20Mint
Benchmark Results: ERC20Transfer
Benchmark Results: Factorial
Benchmark Results: FactorialRecursive
Benchmark Results: Fibonacci
Benchmark Results: FibonacciRecursive
Benchmark Results: ManyHashes
Benchmark Results: MstoreBench
Benchmark Results: Push
Benchmark Results: SstoreBench_no_opt
|
Oppen
approved these changes
Dec 9, 2025
Benchmark for c3bb7a6Click to view benchmark
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We had a regression in our syncing test in Sepolia, this PR reverts main to the latest known commit where the check passed: 3797ce0
Description
This reverts from commit 610df53 up to HEAD (
git revert 610df53^..HEAD), going back to 3797ce0