Skip to content

Conversation

@lakshya-sky
Copy link
Contributor

** Motivation **
Instead of using sender id to get the distance use target provided from the FindNodesMessage which is correct spec.

@lakshya-sky lakshya-sky marked this pull request as ready for review December 10, 2025 17:53
@lakshya-sky lakshya-sky requested a review from a team as a code owner December 10, 2025 17:53
@lakshya-sky lakshya-sky changed the title fix(l1): use correct target to get closest neighbors fix(l1): use correct target to get closest neighbors in discv4 Dec 10, 2025
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@MegaRedHand
Copy link
Collaborator

Hive tests fail due to authentication issues. I'm testing a fix for that in #5596

@MegaRedHand MegaRedHand added this pull request to the merge queue Dec 11, 2025
Merged via the queue into lambdaclass:main with commit 1c4851c Dec 11, 2025
40 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants