Skip to content

feat: remove unnecessary trait bounds in genserver messages (Clone, Sync, Sized) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: remove unnecessary trait bounds in genserver messages (Clone, Sync, Sized) #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f478d5
feat: remove unneeded Clone bounds on GenServer::CaXXMsg
MegaRedHand Sep 15, 2025
0d441cd
feat: remove Sync bounds
MegaRedHand Sep 15, 2025
9b82380
feat: remove Sized bounds
MegaRedHand Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions concurrency/src/tasks/gen_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ pub enum InitResult<G: GenServer> {
}

pub trait GenServer: Send + Sized {
type CallMsg: Clone + Send + Sized + Sync;
type CastMsg: Clone + Send + Sized + Sync;
type OutMsg: Send + Sized;
type CallMsg: Send;
type CastMsg: Send;
type OutMsg: Send;
type Error: Debug + Send;

fn start(self) -> GenServerHandle<Self> {
Expand Down
9 changes: 6 additions & 3 deletions concurrency/src/tasks/time.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ where

let async_block = pin!(async {
rt::sleep(period).await;
let _ = handle.cast(message.clone()).await;
let _ = handle.cast(message).await;
});
let _ = select(cancel_conditions, async_block).await;
});
Expand All @@ -50,6 +50,7 @@ pub fn send_interval<T>(
) -> TimerHandle
where
T: GenServer + 'static,
T::CastMsg: Clone,
{
let cancellation_token = CancellationToken::new();
let cloned_token = cancellation_token.clone();
Expand All @@ -61,9 +62,11 @@ where
let genserver_cancel_fut = pin!(gen_server_cancellation_token.cancelled());
let cancel_conditions = select(cancel_token_fut, genserver_cancel_fut);

let async_block = pin!(async {
let message_clone = message.clone();
let handle_reference = &mut handle;
let async_block = pin!(async move {
rt::sleep(period).await;
let _ = handle.cast(message.clone()).await;
let _ = handle_reference.cast(message_clone).await;
});
let result = select(cancel_conditions, async_block).await;
match result {
Expand Down