Skip to content

Conversation

@devind-ra
Copy link
Contributor

@devind-ra devind-ra commented Nov 20, 2025

Fix for issue in #196

Initially the following flags were added:
image

The result of running ./sbt clean compile test:compile resulted in these warnings:

warning: value scalafixScalaBinaryVersion in object autoImport is deprecated (since 0.12.1): scalafixScalaBinaryVersion now follows scalaVersion by default scalafixScalaBinaryVersion := CrossVersion.binaryScalaVersion(scalaVersion.value), ^

scalafixScalaBinaryVersion := CrossVersion.binaryScalaVersion(scalaVersion.value) was removed and ./sbt clean compile test:compile was ran again and build passed along with all tests passing.

Then with the addition of "-Xfatal-warnings", the build and tests passed correctly.

Flags now in place:
image

@devind-ra devind-ra marked this pull request as draft November 20, 2025 01:08
@devind-ra
Copy link
Contributor Author

Hi @petarcurcin @drmarjanovic, are we allowed to use these flags for scala version 3:

Seq( "-Werror", "-Wunused:all", "-Wvalue-discard", "-deprecation", "-feature", "-unchecked" )

As I had tests issues from the scala version scripts that were being run in the CI pipeline.

@devind-ra devind-ra marked this pull request as ready for review November 20, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant