support authentication with non-default users for Redis clusters #122
+56
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Brabants <[email protected]>
Signed-off-by: Robin Brabants <[email protected]>
robin-brabants
force-pushed
the
feature/redis-cluster-username
branch
from
5ebe723
to
11115cc
Compare
|
@boesing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This small feature allows to pass a username to the RedisCluster constructor from the phpredis extension in order to be able to authenticate with a non-default user. Even though the README does not mention it, passing username and password in the form of an array is supported, see:
Without this feature, one could not connect to a cluster using a user other than the one named 'default'. When using RBAC it is recommended not to connect with the default user anymore by Redis.
This change should be backwards compatible in the sense that if no username option is specified, the phpredis extension will still connect with the default user.
Note: the stubs in Psalm are outdated: https://github.com/phpredis/phpredis/blob/develop/redis_cluster.stub.php#L50