Skip to content

Rename setEventManager parameter #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MadCat34 wants to merge 1 commit into
base: 3.15.x
Choose a base branch
from
Open

Rename setEventManager parameter #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/EventManagerAwareTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ trait EventManagerAwareTrait
* identifiers, in addition to any string or array of strings set to the
* $this->eventIdentifier property.
*/
public function setEventManager(EventManagerInterface $events)
public function setEventManager(EventManagerInterface $eventManager)
{
$identifiers = [self::class, static::class];
if (isset($this->eventIdentifier)) {
Expand All @@ -48,8 +48,8 @@ public function setEventManager(EventManagerInterface $events)
}
// silently ignore invalid eventIdentifier types
}
$events->setIdentifiers($identifiers);
$this->events = $events;
$eventManager->setIdentifiers($identifiers);
$this->events = $eventManager;
if (method_exists($this, 'attachDefaultListeners')) {
$this->attachDefaultListeners();
}
Expand Down