Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use scalafmt to group imports #63

Merged
merged 4 commits into from
Apr 15, 2024
Merged

chore: Use scalafmt to group imports #63

merged 4 commits into from
Apr 15, 2024

Conversation

He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Apr 6, 2024

Motivation:

Use scalafmt to group imports

natsukagami
natsukagami reviewed Apr 6, 2024
View reviewed changes
Copy link
Contributor

@natsukagami natsukagami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm, thanks so much! I thought I'd need scalafix to do this

@He-Pin
Copy link
Contributor Author

He-Pin commented Apr 6, 2024

BTW, I see there is no cleanInput method, but cleanResult, is that by design？

@natsukagami
Copy link
Contributor

cleanInput method, but cleanResult,

Not sure which method you are mentioning here

natsukagami
natsukagami reviewed Apr 8, 2024
View reviewed changes
.scalafmt.conf Outdated Show resolved Hide resolved
@natsukagami natsukagami merged commit c9f1815 into lampepfl:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukagami natsukagami natsukagami left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@He-Pin @natsukagami