Skip to content

Conversation

@jackye1995
Copy link
Contributor

@jackye1995 jackye1995 commented Jan 14, 2026

This PR completes support for credentials vending write

We also make a backwards incompatible change because namespace is not serializable, and we need to reconstruct namespace to do credentials refresh, we instead pass in namespace_impl and namespace_properties so that they are passed around to initialize namespace client in individual workers.

cc @bryanck @jtuglu1

@github-actions github-actions bot added the enhancement New feature or request label Jan 14, 2026
@jackye1995 jackye1995 changed the title feat: support credentials vending write feat!: support credentials vending write Jan 14, 2026
@jackye1995 jackye1995 merged commit a5bd84d into lance-format:main Jan 14, 2026
6 checks passed
@jtuglu1
Copy link

jtuglu1 commented Jan 14, 2026

Cool. Have not taken a deep look yet but is the pattern that every worker will manage their own credential lifetime (e.g. have credential refreshes linear in the # of fragment batches)? E.g. no way for head node to manage refresh once and broadcast it to the workers to avoid something like thundering herd of refreshes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants