-
Notifications
You must be signed in to change notification settings - Fork 521
feat: prune fragments using scalar indices for a given filter #5625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fangbo
wants to merge
12
commits into
lance-format:main
Choose a base branch
from
fangbo:prune_fragments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+481
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
70a05d0 to
9d59e88
Compare
Contributor
Author
|
@jackye1995 @majin1102 @yanghua @wojiaodoubao @Jay-ju This PR is ready. Could you please review it? Thank you. |
4f0f9a8 to
cc4195e
Compare
21df368 to
c360059
Compare
Contributor
|
It seems we already attempted similar work in PR #4835. Maybe we could revisit it. |
c360059 to
95dbef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
We have 10,000 fragments for a dataset. When Spark reads data with filter from the dataset, there will be 10,000 scan tasks, even though the filter can prune the vast majority of fragments. Majority of scan tasks will not read any data. But too many scan tasks degrade the execution efficiency of Spark jobs.
Purpose of this PR
The filter contain's a column which has index. Using the index filter can prune the fragments which should not be scanned.
This PR provides a method
prune_fragmentsfor Dataset. This method prunes some fragments depending on filter and index and returns the fragments need to be scanned.