Skip to content

perf: avoid copying tokens while merging #5661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BubbleCal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: avoid copying tokens while merging #5661

BubbleCal wants to merge 1 commit into from

Conversation

@BubbleCal
Copy link
Contributor

@BubbleCal BubbleCal commented Jan 8, 2026

this also replaces Hashmap with Vec for faster token id lookup

3% faster indexing

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 86.91589% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-index/src/scalar/inverted/merger.rs 86.17% 6 Missing and 7 partials ⚠️
rust/lance-index/src/scalar/inverted/index.rs 92.30% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@BubbleCal BubbleCal requested review from Xuanwo and westonpace January 8, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

@westonpace westonpace Awaiting requested review from westonpace

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BubbleCal