Skip to content

Conversation

@camilesing
Copy link
Contributor

for issue: #5642

@github-actions
Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@camilesing camilesing changed the title faet: Enhance not found errors with suggestions faet: enhance not found errors with suggestions Jan 10, 2026
@wjones127 wjones127 self-assigned this Jan 13, 2026
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start on this. One note is I still think we should put the similarity computation in the Display implementation of the error. You can implement a custom error struct:

struct MyError {
   ...
}


impl std::fmt::Display for MyError {
    ...
}

And then use the #[snafu(transparent)] macro in Snafu to make it one of the variants:

enum Error {
    ...
    #[snafu(transparent)]
    MyError { source: MyError },
    ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants