Skip to content

Conversation

@lichuang
Copy link
Contributor

close #5172 , add support of Utf8View and BinaryView, test these two types in test_query_string

@github-actions github-actions bot added the enhancement New feature or request label Jan 11, 2026
@lichuang
Copy link
Contributor Author

lichuang commented Jan 12, 2026

It seems that the compilation error(https://github.com/lance-format/lance/actions/runs/20890689101/job/60043036449?pr=5685) has nothing to do with the modifications made in this pr. @wjones127

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be able to accomplish this without having to convert in so many places.

Also, could you validate FTS indices build correctly? I think one function you'll need to update is here:

https://github.com/lance-format/lance/blob/5513248362b25daa1c381ef4bfb0da0939a8f4d0/rust/lance-arrow/src/lib.rs#L458-L464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for StringView and BinaryView

2 participants