-
Notifications
You must be signed in to change notification settings - Fork 520
feat: support Utf8View and BinaryView #5685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
It seems that the compilation error(https://github.com/lance-format/lance/actions/runs/20890689101/job/60043036449?pr=5685) has nothing to do with the modifications made in this pr. @wjones127 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
4123e18 to
80f2d92
Compare
wjones127
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be able to accomplish this without having to convert in so many places.
Also, could you validate FTS indices build correctly? I think one function you'll need to update is here:
80f2d92 to
73f8249
Compare
73f8249 to
29c016b
Compare
close #5172 , add support of
Utf8ViewandBinaryView, test these two types intest_query_string