fix: convert bytes slice panic to proper error #5697
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reconstructing byte ranges from split/coalesced I/O requests, `Bytes::slice()` was called without bounds validation. If the returned data was shorter than expected, this would panic instead of returning a meaningful error. Added bounds checking before slice operations in `FileScheduler` and `BufferScheduler`. Fixes lance-format#5674 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bytes::slice()calls inFileScheduler::submit_requestBufferScheduler::satisfy_requestPreviously, if the returned data was shorter than expected (due to file
truncation, corruption, or other issues), the code would panic with "range
end out of bounds". Now it returns a proper error with context about the
expected vs actual buffer size.
Fixes #5674
🤖 Generated with Claude Code