Skip to content

feat: add dynamic header middleware support for rest namespace #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtuglu1 wants to merge 1 commit into from
Closed

feat: add dynamic header middleware support for rest namespace #5715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ lance-io = { version = "=2.0.0-beta.5", path = "./rust/lance-io", default-featur
lance-linalg = { version = "=2.0.0-beta.5", path = "./rust/lance-linalg" }
lance-namespace = { version = "=2.0.0-beta.5", path = "./rust/lance-namespace" }
lance-namespace-impls = { version = "=2.0.0-beta.5", path = "./rust/lance-namespace-impls" }
lance-namespace-reqwest-client = "0.3.1"
lance-namespace-reqwest-client = { path = "../lance-namespace/rust/lance-namespace-reqwest-client" }
lance-table = { version = "=2.0.0-beta.5", path = "./rust/lance-table" }
lance-test-macros = { version = "=2.0.0-beta.5", path = "./rust/lance-test-macros" }
lance-testing = { version = "=2.0.0-beta.5", path = "./rust/lance-testing" }
Expand Down
5 changes: 2 additions & 3 deletions java/lance-jni/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions python/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions rust/lance-io/src/object_store/storage_options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ impl StorageOptionsProvider for LanceNamespaceStorageOptionsProvider {
id: Some(self.table_id.clone()),
version: None,
with_table_uri: None,
..Default::default()
Copy link
Contributor Author

@jtuglu1 jtuglu1 Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the local toml stuff – will be removed.

};

let response = self
Expand Down
11 changes: 10 additions & 1 deletion rust/lance-namespace-impls/src/dir.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,6 +934,7 @@ impl LanceNamespace for DirectoryNamespace {
schema: Some(Box::new(json_schema)),
storage_options,
stats: None,
..Default::default()
})
}
Err(err) => {
Expand All @@ -960,6 +961,7 @@ impl LanceNamespace for DirectoryNamespace {
schema: None,
storage_options,
stats: None,
..Default::default()
})
} else {
Err(Error::Namespace {
Expand Down Expand Up @@ -1156,7 +1158,6 @@ impl LanceNamespace for DirectoryNamespace {
Ok(CreateEmptyTableResponse {
transaction_id: None,
location: Some(table_uri),
properties: None,
storage_options: self.storage_options.clone(),
})
}
Expand Down Expand Up @@ -1987,6 +1988,7 @@ mod tests {
id: Some(vec![]),
page_token: None,
limit: None,
..Default::default()
};
let result = namespace.list_namespaces(list_req).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -2020,6 +2022,7 @@ mod tests {
id: Some(vec!["parent".to_string()]),
page_token: None,
limit: None,
..Default::default()
};
let result = namespace.list_namespaces(list_req).await;
assert!(result.is_ok());
Expand All @@ -2033,6 +2036,7 @@ mod tests {
id: Some(vec![]),
page_token: None,
limit: None,
..Default::default()
};
let result = namespace.list_namespaces(list_req).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -2065,6 +2069,7 @@ mod tests {
id: Some(vec!["test_ns".to_string()]),
page_token: None,
limit: None,
..Default::default()
};
let result = namespace.list_tables(list_req).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -2113,6 +2118,7 @@ mod tests {
id: Some(vec!["test_ns".to_string()]),
page_token: None,
limit: None,
..Default::default()
};
let result = namespace.list_tables(list_req).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -2248,6 +2254,7 @@ mod tests {
// Describe namespace and verify properties
let describe_req = DescribeNamespaceRequest {
id: Some(vec!["test_ns".to_string()]),
..Default::default()
};
let result = namespace.describe_namespace(describe_req).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -2326,6 +2333,7 @@ mod tests {
id: Some(vec!["ns1".to_string()]),
page_token: None,
limit: None,
..Default::default()
};
let result = namespace.list_tables(list_req).await.unwrap();
assert_eq!(result.tables.len(), 1);
Expand All @@ -2335,6 +2343,7 @@ mod tests {
id: Some(vec!["ns2".to_string()]),
page_token: None,
limit: None,
..Default::default()
};
let result = namespace.list_tables(list_req).await.unwrap();
assert_eq!(result.tables.len(), 1);
Expand Down
10 changes: 9 additions & 1 deletion rust/lance-namespace-impls/src/dir/manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,6 +1113,7 @@ impl LanceNamespace for ManifestNamespace {
schema: Some(Box::new(json_schema)),
storage_options: self.storage_options.clone(),
stats: None,
..Default::default()
})
}
Err(_) => {
Expand All @@ -1126,6 +1127,7 @@ impl LanceNamespace for ManifestNamespace {
schema: None,
storage_options: self.storage_options.clone(),
stats: None,
..Default::default()
})
}
}
Expand Down Expand Up @@ -1624,7 +1626,6 @@ impl LanceNamespace for ManifestNamespace {
Ok(CreateEmptyTableResponse {
transaction_id: None,
location: Some(table_uri),
properties: None,
storage_options: self.storage_options.clone(),
})
}
Expand Down Expand Up @@ -2172,6 +2173,7 @@ mod tests {
// Verify namespace exists
let exists_req = NamespaceExistsRequest {
id: Some(vec!["ns1".to_string()]),
..Default::default()
};
let result = dir_namespace.namespace_exists(exists_req).await;
assert!(result.is_ok(), "Namespace should exist");
Expand All @@ -2181,6 +2183,7 @@ mod tests {
id: Some(vec![]),
page_token: None,
limit: None,
..Default::default()
};
let result = dir_namespace.list_namespaces(list_req).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -2225,6 +2228,7 @@ mod tests {
// Verify nested namespace exists
let exists_req = NamespaceExistsRequest {
id: Some(vec!["parent".to_string(), "child".to_string()]),
..Default::default()
};
let result = dir_namespace.namespace_exists(exists_req).await;
assert!(result.is_ok(), "Nested namespace should exist");
Expand All @@ -2234,6 +2238,7 @@ mod tests {
id: Some(vec!["parent".to_string()]),
page_token: None,
limit: None,
..Default::default()
};
let result = dir_namespace.list_namespaces(list_req).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -2301,6 +2306,7 @@ mod tests {
// Verify namespace no longer exists
let exists_req = NamespaceExistsRequest {
id: Some(vec!["ns1".to_string()]),
..Default::default()
};
let result = dir_namespace.namespace_exists(exists_req).await;
assert!(result.is_err(), "Namespace should not exist after drop");
Expand Down Expand Up @@ -2379,6 +2385,7 @@ mod tests {
id: Some(vec!["ns1".to_string()]),
page_token: None,
limit: None,
..Default::default()
};
let result = dir_namespace.list_tables(list_req).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -2415,6 +2422,7 @@ mod tests {
// Describe the namespace
let describe_req = DescribeNamespaceRequest {
id: Some(vec!["ns1".to_string()]),
..Default::default()
};
let result = dir_namespace.describe_namespace(describe_req).await;
assert!(
Expand Down
2 changes: 1 addition & 1 deletion rust/lance-namespace-impls/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pub use credentials::azure::{AzureCredentialVendor, AzureCredentialVendorConfig}
pub use credentials::azure_props;

#[cfg(feature = "rest")]
pub use rest::{RestNamespace, RestNamespaceBuilder};
pub use rest::{HeaderProvider, RestNamespace, RestNamespaceBuilder, StaticHeaderProvider};

#[cfg(feature = "rest-adapter")]
pub use rest_adapter::{RestAdapter, RestAdapterConfig, RestAdapterHandle};
Loading
Loading