Open
Conversation
Extractomat: Add Dutch and German
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to extend the extractomat's support for Dutch and French languages
During experimentation with ACTER data (notebook), we have discovered that the default implementation of extractomat returns no entities for French and Dutch languages. For Dutch, the issue was solved by extending UPOS to the Penn mapping dictionary, while for French, the problem was due to incorrect processing of space tokens. The latter was fixed by introducing a simple if statement to filter out spaces in the lemmatization. The space token was now allowed in input and discarded at lemmatization.
TLDR
To introduce French to extractomat, we did:
"SPACE": "NN"at line 56 to the UPOS mappingget_lemmatized_phrasefunctionTo add Dutch to extractomat, we