Skip to content

Conversation

@mdrxy
Copy link
Collaborator

@mdrxy mdrxy commented Sep 18, 2025

https://docs.langchain.com/oss/python/releases/langchain-v1
https://googleapis.dev/python/generativelanguage/latest/

CHANGELOG

TODO

  • Remove convert_system_message_to_human (langchain_google_genai/chat_models.py:2303)

return await _achat_with_retry(**params)


def _is_lc_content_block(part: dict) -> bool:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed gratuitous

return "type" in part


def _is_openai_image_block(block: dict) -> bool:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use util from core instead of redefining here as the logic is the same

thought_signature=thought_sig,
)
)
elif part["type"] == "reasoning":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of implementing both this and _convert_from_v1_to_generativelanguage_v1beta?

afaik this code is never engaged because _convert_from_v1_to_generativelanguage_v1beta filters out of content.

@ccurme ccurme marked this pull request as ready for review October 16, 2025 15:21
@ccurme ccurme merged commit 2be3960 into main Oct 16, 2025
47 checks passed
@ccurme ccurme deleted the v3.0.0 branch October 16, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants