Skip to content

test simple middleware / no statefulness changes #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test simple middleware / no statefulness changes #317

wants to merge 2 commits into from

Conversation

@eyurtsev
Copy link
Collaborator

  • test
  • no statefulness

eyurtsev
eyurtsev commented Sep 18, 2025
View reviewed changes
langchain_mcp_adapters/middleware.py

# Do we want to make tools a property? Or support an async method?
@property
def tools(self) -> list[BaseTool]:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Life cycle management is bad

Would want to be able to do some async initialization to get a list of tools from the server.

  1. Requires changing tools into a property
  2. Requires running code on a thread to spawn another event loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eyurtsev