-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain: Bump ruff version to 0.9 #29211
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
4d0d1d4
to
b8fc3fc
Compare
libs/langchain/pyproject.toml
Outdated
@@ -119,7 +120,7 @@ cassio = "^0.1.0" | |||
langchainhub = "^0.1.16" | |||
|
|||
[tool.poetry.group.lint.dependencies] | |||
ruff = "^0.5" | |||
ruff = "~0.9.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep this as ^0.9
to avoid auto updating and pulling in breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking changes can happen between minor versions in ruff (new rules, different formatting).
^0.9
is equivalent to >=0.9, <1.0.0
whereas ~0.9.1
is equivalent to >=0.9, <0.10.0
. So I think the latter is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL they're actually equivalent in this case https://python-poetry.org/docs/dependency-specification/#caret-requirements
we tend to use ^
across other dependencies so will keep there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes for version <1, caret rules are different ! (TIL too 😄)
No description provided.