Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain: Bump ruff version to 0.9 #29211

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Jan 14, 2025

No description provided.

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 0:22am

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. langchain Related to the langchain package 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jan 14, 2025
@cbornet cbornet force-pushed the ruff-0.9-langchain branch from 4d0d1d4 to b8fc3fc Compare January 15, 2025 10:27
@@ -119,7 +120,7 @@ cassio = "^0.1.0"
langchainhub = "^0.1.16"

[tool.poetry.group.lint.dependencies]
ruff = "^0.5"
ruff = "~0.9.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this as ^0.9 to avoid auto updating and pulling in breaking changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes can happen between minor versions in ruff (new rules, different formatting).
^0.9 is equivalent to >=0.9, <1.0.0 whereas ~0.9.1 is equivalent to >=0.9, <0.10.0. So I think the latter is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL they're actually equivalent in this case https://python-poetry.org/docs/dependency-specification/#caret-requirements

we tend to use ^ across other dependencies so will keep there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes for version <1, caret rules are different ! (TIL too 😄)

@efriis efriis self-assigned this Jan 16, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 22, 2025
@efriis efriis enabled auto-merge (squash) January 22, 2025 00:22
@efriis efriis merged commit a004dec into langchain-ai:master Jan 22, 2025
31 checks passed
@cbornet cbornet deleted the ruff-0.9-langchain branch January 22, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants