Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Tilores provider and tools #29244

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Conversation

stefan-berkner-tilotech
Copy link
Contributor

Description: This PR adds documentation for the Tilores provider and tools.
Issue: closes #26320

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 0:31am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jan 16, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like maintainers don't have permission to edit this PR. Would you mind adding

- name: tilores-langchain
  path: .
  repo: tilotech/tilores-langchain
  downloads: 0

to the bottom of packages.yml? (The downloads will be auto-populated in the docs.)

Other than that, there are what look like secret strings in the docs, these should be sanitized.

@stefan-berkner-tilotech
Copy link
Contributor Author

After the latest changes I see the Vercel deployment failing.

ValueError: Provider page not found for tilores-langchain. Please add one at docs/integrations/providers/tilores-langchain.{mdx,ipynb}

Does the name in packages.yml maybe need to be inverted?
Like this:

- name: langchain-tilores
  path: .
  repo: tilotech/tilores-langchain
  downloads: 0

@ccurme
Copy link
Collaborator

ccurme commented Jan 20, 2025

@stefan-berkner-tilotech Let's also specify the provider_page key:

- name: tilores-langchain
  path: .
  repo: tilotech/tilores-langchain
  provider_page: tilores
  downloads: 0

Thanks!

@ccurme ccurme self-assigned this Jan 20, 2025
@stefan-berkner-tilotech
Copy link
Contributor Author

Should be ready now. Any feedback on the public read-only demo credentials?

@ccurme
Copy link
Collaborator

ccurme commented Jan 22, 2025

Should be ready now. Any feedback on the public read-only demo credentials?

Thanks, looks good! On the demo credentials, in my opinion it's best to link to a page in your docs, so they don't need to be maintained separately in the LangChain docs.

@ccurme ccurme merged commit 8977451 into langchain-ai:master Jan 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

DOC: Add tooling for Tilores entity resolution SDK
2 participants