fix(core): support (message class, template) tuples in ChatPromptTemplate.from_messages #33989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the incomplete conversion logic in
ChatPromptTemplate.from_messagesthat prevented the documented(message class, template)tuple syntax from working.Previously, passing tuples like
(HumanMessage, "{input}")raised a Pydantic validation error becauseBaseMessagesubclasses were not handled.This adds the missing branch that detects message classes with a
typefield and creates the appropriate template using_create_template_from_message_type.Changes
_convert_to_message_templateto properly support(message class, template)tuples.HumanMessage,AIMessage, andSystemMessage.Issue
Fixes #33791
Dependencies
None
Noting that the failing Pydantic tests are also failing on main right now.
This PR appears unrelated to the breakage.