Skip to content

fix: align cron schedule target help #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HwangJohn wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −12
Open

fix: align cron schedule target help #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,11 +295,11 @@ export function parseCommand(argv: string[]): CliCommand {

if (argv[1] === "pause" || argv[1] === "resume" || argv[1] === "delete") {
const target = parseIngestionTarget(argv[2] ?? "");
if (!target || typeof target !== "string" || argv.length > 3) {
if (target !== "all" || argv.length > 3) {
return {
kind: "error",
exitCode: 1,
message: `Usage: openwiki cron ${argv[1]} <source|all>`,
message: `Usage: openwiki cron ${argv[1]} all`,
};
}

Expand All @@ -316,7 +316,7 @@ export function parseCommand(argv: string[]): CliCommand {
kind: "error",
exitCode: 1,
message:
"Usage: openwiki cron list | pause <source|all> | resume <source|all> | delete <source|all>",
"Usage: openwiki cron list | pause all | resume all | delete all",
};
}
}
Expand Down Expand Up @@ -580,9 +580,9 @@ export const helpContent: HelpContent = {
"openwiki auth tools <provider>",
"openwiki ingest <source|source-instance|all>",
"openwiki cron list",
"openwiki cron pause <source|all>",
"openwiki cron resume <source|all>",
"openwiki cron delete <source|all>",
"openwiki cron pause all",
"openwiki cron resume all",
"openwiki cron delete all",
"openwiki ngrok start [url] [--port <port>]",
],
commands: [
Expand Down Expand Up @@ -625,17 +625,17 @@ export const helpContent: HelpContent = {
description: "List saved connector schedules and local launchd status.",
},
{
label: "openwiki cron pause <source|all>",
label: "openwiki cron pause all",
description:
"Pause saved connector schedules and reconcile the Mac wake window.",
},
{
label: "openwiki cron resume <source|all>",
label: "openwiki cron resume all",
description:
"Resume paused connector schedules and reconcile the Mac wake window.",
},
{
label: "openwiki cron delete <source|all>",
label: "openwiki cron delete all",
description:
"Delete saved connector schedules and remove stale local schedule files.",
},
Expand Down Expand Up @@ -692,9 +692,9 @@ export const helpContent: HelpContent = {
"openwiki ingest web-search",
"openwiki ingest web-search-2",
"openwiki cron list",
"openwiki cron pause web-search",
"openwiki cron resume web-search",
"openwiki cron delete web-search",
"openwiki cron pause all",
"openwiki cron resume all",
"openwiki cron delete all",
"openwiki auth slack",
"openwiki auth gmail",
"openwiki auth notion",
Expand Down
5 changes: 5 additions & 0 deletions test/commands.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,11 @@ describe("parseCommand — cron", () => {
expect(result.kind).toBe("error");
});

test("cron pause with a source id is rejected", () => {
const result = parseCommand(["cron", "pause", "web-search"]);
expect(result.kind).toBe("error");
});

test("cron resume with a source instance id is rejected", () => {
const result = parseCommand(["cron", "resume", "web-search-1"]);
expect(result.kind).toBe("error");
Expand Down