fix: preserve customized workflow file instead of unconditionally overwriting (#316)#319
Open
Himanshu Kumar (himanshu231204) wants to merge 2 commits into
Conversation
added 2 commits
July 14, 2026 01:09
The isValidModelId regex required the first character to be alphanumeric, rejecting Cloudflare Workers AI model IDs like @cf/meta/llama-3-8b-instruct. Add '@' to the allowed first character set. Fixes langchain-ai#315
…rwriting The workflow write was unconditional, destroying user customizations (cron schedule, fork guards, env vars, etc.) on every run. The generated wiki then documented the overwritten defaults rather than the user's actual config. Now writeCodeModeWorkflow() checks for an existing file first and only creates the workflow when it doesn't exist, matching the existing preserve-by-default pattern used for agent snippet files. Adds tests verifying: - Workflow is created when absent - Existing customized workflow is preserved as-is - Idempotent across repeated runs Fixes langchain-ai#316
Contributor
Author
|
Colin Francis (@colifran) Could you review this fix for #316? The workflow file was being unconditionally overwritten on every run. Now it only creates the file when missing, preserving any user customizations. All tests pass. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #316
writeCodeModeWorkflow() in src/code-mode.ts unconditionally overwrote .github/workflows/openwiki-update.yml on every openwiki code run, destroying user customizations (cron schedule, fork guards, env vars, pinned actions, etc.). The generated wiki then documented the overwritten defaults instead of the actual config.
Changes:
All 7 code-mode tests pass.