fix: validate openai-compatible base urls#329
Open
HwangJohn wants to merge 5 commits into
Open
Conversation
HwangJohn
marked this pull request as ready for review
July 14, 2026 12:26
Colin Francis (colifran)
previously approved these changes
Jul 14, 2026
Colin Francis (colifran)
left a comment
Contributor
There was a problem hiding this comment.
Nice one! Thanks HwangJohn!
Contributor
|
HwangJohn - can you take a look at the failing lint check and the failing test here? |
Contributor
Author
|
Thanks for the heads up. I pushed a follow-up that merges the latest main, resolves the conflicts, and fixes the env-behavior test to use the dynamically imported env module. Locally verified with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/chat/completionsinstead of the API rootFixes #326.
Testing
corepack pnpm exec prettier --check src/constants.ts src/agent/index.ts src/credentials.tsx src/env.ts test/constants.test.ts test/env-behavior.test.tscorepack pnpm run typecheckcorepack pnpm exec vitest run test/constants.test.ts test/env-behavior.test.ts(fails only on the existing Windows chmod assertion intest/env-behavior.test.ts > writes the env file with 0600 permissions; the new base URL tests pass)