Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pull types call out of the main page #7116

Merged
merged 7 commits into from
Mar 19, 2025
Merged

refactor: pull types call out of the main page #7116

merged 7 commits into from
Mar 19, 2025

Conversation

mfortman11
Copy link
Collaborator

@mfortman11 mfortman11 commented Mar 17, 2025

Adds some easy performance improvements by taking the types call off of the main landing page

Frontend Data Fetching Optimization:

  • Simplified data fetching logic in AppInitPage by removing dependency on typesLoaded and directly invoking data fetching hooks (useGetGlobalVariables, useGetTagsQuery, useGetFoldersQuery, useGetBasicExamplesQuery). [1] [2]
  • Introduced useGetTypes and useTypesStore in FlowPage to manage type data more effectively, ensuring data is fetched only when necessary.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Mar 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 17, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 17, 2025
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #7116 will degrade performances by 26.54%

Comparing lfoss-762 (3cb1beb) with main (9f331d6)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cancel_build_with_cancelled_error 255.4 ms 222.4 ms +14.84%
test_cancel_nonexistent_build 7.8 ms 10.6 ms -26.54%
test_get_all 649 ms 744.9 ms -12.86%

@lucaseduoli
Copy link
Collaborator

GZipMiddleware doesn't work with the Streaming mode, only with the Polling mode.

@mfortman11
Copy link
Collaborator Author

GZipMiddleware doesn't work with the Streaming mode, only with the Polling mode.

Good callout I'll make this as do not merge for now

@mfortman11 mfortman11 added the DO NOT MERGE Don't Merge this PR label Mar 17, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 19, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 19, 2025
@mfortman11 mfortman11 changed the title feat: add compression and pull types call out of the main page refactor: pull types call out of the main page Mar 19, 2025
@mfortman11 mfortman11 added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. DO NOT MERGE Don't Merge this PR labels Mar 19, 2025
@github-actions github-actions bot removed the enhancement New feature or request label Mar 19, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 19, 2025
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Mar 19, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 19, 2025
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 19, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 19, 2025
@mfortman11 mfortman11 enabled auto-merge March 19, 2025 17:50
@mfortman11 mfortman11 added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit a75542c Mar 19, 2025
18 checks passed
@mfortman11 mfortman11 deleted the lfoss-762 branch March 19, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants