-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pull types call out of the main page #7116
Conversation
CodSpeed Performance ReportMerging #7116 will degrade performances by 26.54%Comparing Summary
Benchmarks breakdown
|
GZipMiddleware doesn't work with the Streaming mode, only with the Polling mode. |
Good callout I'll make this as do not merge for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds some easy performance improvements by taking the types call off of the main landing page
Frontend Data Fetching Optimization:
AppInitPage
by removing dependency ontypesLoaded
and directly invoking data fetching hooks (useGetGlobalVariables
,useGetTagsQuery
,useGetFoldersQuery
,useGetBasicExamplesQuery
). [1] [2]useGetTypes
anduseTypesStore
inFlowPage
to manage type data more effectively, ensuring data is fetched only when necessary.