Add Ai Suffix to account creation URL - #90
Conversation
Updated the URL for creating a Langfuse account to the AI cloud version.
|
@claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| ``` | ||
| If `LANGFUSE_BASE_URL` is used instead of `LANGFUSE_HOST`, run `export LANGFUSE_HOST="$LANGFUSE_BASE_URL"`. | ||
| If not set, ask the user to set them in their shell or a `.env` file. Keys are found in the Langfuse project under Settings -> API Keys; the user should create a project API key pair there. If they do not have a Langfuse account yet, share that they can create one for free at `https://langfuse.com/cloud`. Do not ask them to paste keys into chat for security reasons. | ||
| If not set, ask the user to set them in their shell or a `.env` file. Keys are found in the Langfuse project under Settings -> API Keys; the user should create a project API key pair there. If they do not have a Langfuse account yet, share that they can create one for free at `https://langfuse.com/cloud-ai`. Do not ask them to paste keys into chat for security reasons. |
There was a problem hiding this comment.
🔴 This PR fixes the Langfuse account-creation URL in skills/langfuse/SKILL.md but doesn't bump .claude-plugin/plugin.json / .cursor-plugin/plugin.json (both remain at 1.4.4). Per AGENTS.md's 'Plugin Version Bumps' section, this qualifies as a 'small content correction,' which is patch-bump-worthy, and both manifests must be bumped together in the same PR — please bump both to 1.4.5.
Extended reasoning...
What's missing: AGENTS.md's Plugin Version Bumps section requires that whenever published skill behavior changes, .claude-plugin/plugin.json and .cursor-plugin/plugin.json be bumped together to the same version, in the same PR as the change. This PR changes the account-creation URL that the skill hands to users (from https://langfuse.com/cloud to https://langfuse.com/cloud-ai) but leaves both manifests at 1.4.4.
Why this isn't exempt: AGENTS.md carves out only three no-bump categories: typo fixes, formatting, and comment-only changes. This change is none of those — it's a deliberate correction to the actual destination URL a user is told to visit, i.e. observable, published skill behavior. That places it squarely in the 'small content corrections' / 'bug fixes in a skill' bucket, which the same section explicitly maps to a patch bump. The commit title itself ('Fix Langfuse account creation URL') confirms this is a fix, not cosmetic. AGENTS.md also adds a tie-breaker for ambiguous cases — 'If unsure whether a change warrants a bump, err on the side of bumping patch' — removing any doubt here.
Step-by-step proof:
- Diff touches only
skills/langfuse/SKILL.md, changinghttps://langfuse.com/cloud→https://langfuse.com/cloud-ai(line 74). - Check
.claude-plugin/plugin.jsonand.cursor-plugin/plugin.json: both still read"version": "1.4.4". - Classify the change against AGENTS.md's bump table: not typo/formatting/comment-only (excluded list) → falls under 'small content corrections' → Patch bump required.
- AGENTS.md: 'Both manifests have a version field and must stay in lockstep — always bump them together to the same value, in the same PR as the change.' Neither was touched, so the rule is violated.
Why existing process doesn't catch it: there's no automated version-bump check in CI for this repo (based on the PR's file list, only SKILL.md changed) — this is a manual convention enforced purely through the AGENTS.md review checklist, which explicitly lists 'Version bumps in lockstep' as a required check for reviewers to apply. Because it's a repo-mandated, non-subjective rule (not a style preference), it should be treated as a real, fixable defect rather than a nit.
Fix: bump version to 1.4.5 in both .claude-plugin/plugin.json and .cursor-plugin/plugin.json in this PR.
1 participant
Updated the URL for creating a Langfuse account to the AI cloud version.