Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postgresql-specific default values in model definition #15653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whhe
Copy link

@whhe whhe commented Mar 12, 2025

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Resolves #15411

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Mar 12, 2025
@crazywoola
Copy link
Member

I think this will introduce breaking changes to our existing system, please provide a fallback plan as well.

@whhe whhe force-pushed the table-default-values branch from cc5b7cd to 26a5bfe Compare March 12, 2025 12:38
@whhe
Copy link
Author

whhe commented Mar 12, 2025

I think this will introduce breaking changes to our existing system, please provide a fallback plan as well.

This change is not expected to introduce changes to the table structure. Which part do you think may break the existing design?

@crazywoola
Copy link
Member

@laipz8200 Thoughts?

@laipz8200 laipz8200 self-requested a review March 13, 2025 05:19
@laipz8200
Copy link
Member

will check it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the dependency on postgresql for table default values
3 participants