Restrict commands/filenames to ASCII and uses the tool runtime #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breaking: file edits are limited to 1k edits (previously unbounded)
DDGS is flaky, stub it to avoid test errors
mikegros
reviewed
Jan 27, 2026
| from ursa.tools.write_code_tool import edit_code, write_code | ||
|
|
||
|
|
||
| def test_write_code_strips_fences_and_writes(tmp_path: Path): |
Collaborator
There was a problem hiding this comment.
I think we can actually remove this test because it looks like we are going to remove the _strip_fences function (because it actually causes problems instead of fixing them now).
mikegros
reviewed
Jan 27, 2026
Collaborator
mikegros
left a comment
mikegros
left a comment
There was a problem hiding this comment.
I'll look over more but wanted to get this out to you.
| print("[READING]: ", full_filename) | ||
| try: | ||
| if full_filename.lower().endswith(".pdf"): | ||
| if full_filename.suffix == ".pdf": |
Collaborator
There was a problem hiding this comment.
Suggested change
| if full_filename.suffix == ".pdf": | |
| if full_filename.suffix.lower() == ".pdf": |
Doesn't this need to keep the "lower" to ensure it's not case sensitive (some pdf files end in .PDF rather than .pdf for instance)
|
|
||
| def safety_check(self, state: ExecutionState) -> ExecutionState: | ||
| def safety_check( | ||
| self, state: ExecutionState, runtime: Runtime[AgentContext] |
Collaborator
There was a problem hiding this comment.
This appears to fail for me in any uses of the execution agent that traverse the graph because it needs two arguments but in the graph it only gets the state passed into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update type annotation on run_command, write_code and edit_code to restrict filenames/commands to "text" ASCII (so no command symbols). This turns out to be zero cost on OpenAI as they support providing a grammar for decoding
Along the way, also swapped the tools to use LangGraph's ToolRuntime (instead of the older split out types). The win here:
@mikegros as a side effect, I think this also fixes the parallel tool call error when calling write_code/edit_code