Add anchors for easier subheading linking #292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +32,7 @@ Multiple rules may be delimited using either a "pipe" character, or as separate | |||
| array('name' => array('required', 'min:5')) | |||
| ); | |||
|
|
|||
| Once a `Validator` instance has been created, the `fails` (or `passes`) method may be used to perform the validation. | |||
| Once a `Validator` instance has been created, the `fails` (or `passes`) method may be used to perform the validation. | |||
There was a problem hiding this comment.
What is this massive space?
There was a problem hiding this comment.
That's where my positive attitude used to be.
|
Other than the space, which will only damage Taylor's OCD, it looks great! Thanks :) |
… the docs easier.
|
Haha nice Dayle. I fixed the spacing issue introduced in the commit. |
|
I like the general idea, but shouldn't this be done in the tool that parses the MarkDown files and displays them? |
|
Hi @piotrowski , could you target the 4.1 branch for this please? Thanks! :) |
|
Sorry, wat? Not my PR, so I can't do anything, right? |
|
This was my PR, but I'm not at a place where I can update and resubmit this. If someone else wants to tackle it, that'd be awesome. |
|
Sorry @piotrowski , I tagged the wrong username :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be useful to add anchors for sub-headings so people could link to sub-sections of the docs more precisely.