[12.x] Add prepend option for Str::plural() #56802
Open
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we reach for the
Str::plural()
helper, we frequently want to prepend the string itself with the$count
that's being passed in. That typically looks something like this:This PR cleans up the repetition a bit, by adding an optional
prepend
parameter to theStr::plural()
method. Here's what the above looks like, when using that option:The parameter defaults to
false
, so a non-breaking change. Tests included, and added a couple of extras that I think are mostly covered by the Pluralizer...but thought it might be helpful to ensure we don't get any unexpected$count
prepending when this new param is not in use, since the Pluralizer isn't aware of that piece. Let me know if there's anything I can change or help with, here! Happy to update docs as well, if this gets merged.