Rules are not applied when "empty" is specified for the preset #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a bug where the rules written in the rules section are not applied when the following settings are written in pint.json:
I made a fix because
ConfigurationFactory::preset([])
is not called unless "empty" is added to the available presets.I tried writing the following code and compared the cases where "empty" is not present in $presets and where it is present:
When "empty" is not present:
When "empty" is present:
It can be seen that the rules are correctly applied.