Valet/Herd Preference + Smarter Detection #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, oddly enough, I use Valet+PHPMonitor and Herd separately and at times swap between them, and discovered that once Herd is installed, the Vite plugin breaks when I try to use this plugin with pure valet sites since the plugin looks for Herd configs first and ignores valet after that.
To remedy this, I added an env
LARAVEL_PREFER_DEVELOPMENT_ENVIRONMENT(which can beherdorvalet) that will prefer one or the other if both exist.I also added "smarter" detection for these certificates by checking for certificates of the current site in all available directories first instead of choosing Herd first just because its
valetdirectory exists.