Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
+ Coverage 90.01% 90.06% +0.04%
==========================================
Files 52 52
Lines 8054 8089 +35
==========================================
+ Hits 7250 7285 +35
Misses 804 804
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@MegaIng Any chance you can give it a quick look? |
|
IMO we should exclude While reading through the logs I noticed that coverage can't parse |
MegaIng
left a comment
There was a problem hiding this comment.
The implementation looks good, we should just exclude the file from coverage.
The regression with subclasses is annoying, but I agree that this should be rare. It's jut a limitation of python's typing system not having HKTs
|
Looks ok? |
Fixes #1186
One regression: subclasses of Lark using open() etc. will see a regression. But arguably it is pretty unusual, and we're fixing the much more common use-case.