Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #161
When a workflow filename starts with a number (e.g.,
1-release.yaml), the action incorrectly treats it as a workflow ID instead of a filename. This happens because JavaScript'sparseFloat("1-release.yaml")returns 1, causing the action to skip the workflow ID lookup and attempt to dispatch workflow ID 1 directly.Solution
Introduced a new
getWorkflowIdFromValue()function that uses a strict regex(/^\d+$/)to only match strings consisting entirely of digits. This ensures filenames like1-release.yamlare correctly treated as filenames, while pure numeric strings like123456are still recognized as workflow IDs.Changes
getWorkflowIdFromValue()for strict integer-only parsing of workflow IDsgetNumberFromValue()by removing unnecessary try-catch