-
Notifications
You must be signed in to change notification settings - Fork 110
Feature/adjoint flow #1526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/adjoint flow #1526
Conversation
initialize dslash_type_precondition fix CMake to use QUDA_DIRAC_LAPLACE instead of old QUDA_LAPLACE
…ds. Revert prior change to color_spinor_util.in.cu.
refined errors tests |
@maddyscientist This looks pretty goof from my perspective, if you give it the once over for @rkarur we can merge and I can refactor into classes as a separate PR. |
The test executable
Smear type "1" is stout smearing, which is the default specified in the command_line_params files. Should we change the default there, or manually override it in |
This also fails an error check after manually specifying
Symanzik has the same issue. |
Further, it looks like setting the precision with Lines 75 to 80 of the test executable:
If there's a reason for this that's fine, but there should be a |
This was a bug: fixed in my cleanup. |
This was due to requesting too tight a tolerance in double precision. Fixed. |
Fixed in my cleanup: the default smear type is Stout (which is inherited from pre-existing state). If the user doesn't specify, then Wilson-flow is now set (and a message printed to this effect). |
This is great addition @rkarur, thank you. I have cleaned up the test a bit, and it now uses google test when the I'm approving this PR now, but before we merge we should wait for @weinbe2's sign off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me. Thanks @rkarur and @maddyscientist !
Implemented the adjoint fermion flow algorithm (both the serial and hierarchical versions detailed in Appendix E of https://arxiv.org/pdf/1302.5246) and wrote a test that tests both the adjoint and regular (forward) gradient flow, in which the equivalence of the serial and hierarchical methods is demonstrated, as well as a numerical verification that the forward and adjoint fermionic flows are indeed adjoint methods of one another (Identity E.4 in https://arxiv.org/pdf/1302.5246)