-
Notifications
You must be signed in to change notification settings - Fork 110
MMA-optimized batched MRHS MG #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maddyscientist
wants to merge
32
commits into
develop
Choose a base branch
from
feature/mg-mma-misc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r operators; delay enablement of MMA in transfer until after coarse operator is computed to avoid double storage of V in MMA order; only store V in native or MMA order to reduce memory
…rn_residual, use_init_guess. These can now be updated using the Solver::update_param interface
…mer for the latter to reduce memory consumption
… This is helpful for unform object creation.
…lied using tensor cores
…ngle MMA-ordered super-system: prolongator, restrictor and dslash coarse will now not reorder if the input / output fields are already in the correct order
…ith a ColorSpinorField; deploy this to check if we need to nuke any preexisting allications when resizing std::vector<ColorSpinorField>
…eferences around the input (useful for creating a uniform code path between native and MMA ordered solvers)
…ew parameter QudaMultigridParam::collapse_mrhs enables this on a per level basis, with MMA enablement for both dslash and transfer operator (on the finer level) required; deflation is presently handled by expanding the collapsed space to the batch form, and then collapsing again post deflation. This removes all the BlockTranspose operations outside of the initial coarsening and final prolongation (deflation excepting).
…this fixes the verify routine with MMA transfer routines when using half precision
hummingtree
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up to make MMA/MG more accessible! Just have a small request for comments.
…arer. Remove unused function.
…e tune parameters to avoid accidental overwriting of a real tunecache (closes #1558)
This was referenced Apr 26, 2025
Merged
…egation transfer operators
…at is not a divisor of Nsrc
…ature/mg-mma-misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on improving the use of MMA with batched multigrid, resulting in the optimal MRHS multigrid performance:
QudaMultigridParam::collapse_mrhs
(--mg-collapse-mrhs
from the command line)vector_ref<ColorSpinorField>::size_actual()
to allow us to query the number of RHS in a collapsed systemFieldTmp
BlockTranspose
input field set can now be in half precision